-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add help cli #775
feat: Add help cli #775
Conversation
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
===========================================
+ Coverage 75.16% 94.10% +18.94%
===========================================
Files 88 95 +7
Lines 4852 5429 +577
Branches 196 431 +235
===========================================
+ Hits 3647 5109 +1462
+ Misses 1200 319 -881
+ Partials 5 1 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 52 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a solid start! Left some comments around refactors, but I'm very into the general visuals you're going with. 🚀
@JoshuaKGoldberg I just wanted to give you a progress update:
|
Hi @JoshuaKGoldberg! I think I've covered everything that came up in this conversation, so I've marked the PR as ready for review. I am of course willing to work on any additional feedback! I've been getting an error on one of the e2e tests,
|
Yeah sorry about the migrate test noise - it's not related to this PR. You were right to check on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful 🚀! This is shaping up really nicely. Thanks for iterating on it!
I left some cleanup comments - a few are just style nitpicks, and a few are more structural. Please do let me know if you think I'm off base on any of them (or just want to chat alternatives)! ❤️
Don't forget to reference the issue 😄 |
I've also excluded the help snapshot from the cspell linter as it was causing it to fail. |
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@all-contributors please add @dominicduffin1 for code.
|
I've put up a pull request to add @dominicduffin1! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
🎉 This is included in version v1.43.0 🎉 The release is available on: Cheers! 📦🚀 |
Adds @dominicduffin1 as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#775 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
PR Checklist
status: accepting prs
Overview
I've added functionality to print to the terminal help documentation based on the existing docs when the
--help
or-h
terminal flags are used.This will run in place of the functionality.
I've marked this as a draft PR as I have a few questions so it is not yet complete, maybe you can assist @JoshuaKGoldberg :
parseargs
" to check for missing options (from the issue).Beyond that, is what I've included and how I've formatted the printout what you were expecting?