Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm badge to readme #880

Merged
merged 7 commits into from
Sep 24, 2023
Merged

feat: add npm badge to readme #880

merged 7 commits into from
Sep 24, 2023

Conversation

jaas666
Copy link
Contributor

@jaas666 jaas666 commented Sep 23, 2023

PR Checklist

Overview

Added npm version badge to readme file. Also added it to the template that creates the file: src/steps/writeReadme/generateTopContent.ts

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #881: functionally looks great, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Sep 23, 2023
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Sep 23, 2023
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually, it looks like there are a few more test failures. You'll want to pnpm run test -u locally to update snapshots. LMK if that gives you any issues?

@jaas666
Copy link
Contributor Author

jaas666 commented Sep 24, 2023

Yikes. I think I failed to include one updated file. How about now?

All test are passing locally

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #880 (6582899) into main (f38a7fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          89       89           
  Lines        4670     4674    +4     
  Branches      358      358           
=======================================
+ Hits         4332     4336    +4     
  Misses        337      337           
  Partials        1        1           
Flag Coverage Δ
create 70.83% <100.00%> (+0.02%) ⬆️
initialize 35.43% <0.00%> (-0.04%) ⬇️
migrate 70.16% <100.00%> (+0.02%) ⬆️
unit 60.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writeReadme/generateTopContent.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did it! I did the merge from main and resolved merge conflicts by just re-applying the same changes you did in this PR. 💯 Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit e199ea9 into JoshuaKGoldberg:main Sep 24, 2023
@jaas666 jaas666 deleted the issue_730 branch September 24, 2023 22:29
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add npm version badge to README.md (and template)
2 participants