-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add npm badge to readme #880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to #881: functionally looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually, it looks like there are a few more test failures. You'll want to pnpm run test -u
locally to update snapshots. LMK if that gives you any issues?
Yikes. I think I failed to include one updated file. How about now? All test are passing locally |
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 89 89
Lines 4670 4674 +4
Branches 358 358
=======================================
+ Hits 4332 4336 +4
Misses 337 337
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did it! I did the merge from main
and resolved merge conflicts by just re-applying the same changes you did in this PR. 💯 Thanks!
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Added npm version badge to readme file. Also added it to the template that creates the file:
src/steps/writeReadme/generateTopContent.ts