-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aged away label #881
feat: add aged away label #881
Conversation
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 92.77% 92.78%
=======================================
Files 89 89
Lines 4636 4641 +5
Branches 355 355
=======================================
+ Hits 4301 4306 +5
Misses 334 334
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally looks good, thanks! Just requesting changes on running the formatter.
I think I know what's the issue. I'll fix it later today.
…On Sat, Sep 23, 2023, 9:15 AM Josh Goldberg ✨ ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Functionally looks good, thanks! Just requesting changes on running the
formatter.
------------------------------
In src/steps/initializeGitHubRepository/labels/outcomeLabels.ts
<#881 (comment)>
:
> - {
- color: "a2eeef",
- description: "New enhancement or request",
- name: "type: feature",
- },
- {
- color: "d876e3",
- description: "Further information is requested",
- name: "type: question",
- },
- {
- color: "fde282",
- description: "Tech debt or other code/repository cleanups",
- name: "type: cleanup",
- },
+ {
- +
Hmm, looks like whatever formatter is being applied on the files isn't
matching this repository's Prettier <https://prettier.io> settings. Which
is why the diff view of these files is so big - all the indentation changed
from \t tabs to two spaces.
https://github.com/JoshuaKGoldberg/create-typescript-app/blob/bfcd795a077a9e4409dce9f99569a5325456bae2/.github/DEVELOPMENT.md
should have instructions for getting set up locally. Let me know if any of
that's unclear / doesn't work on your end!
—
Reply to this email directly, view it on GitHub
<#881 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGOB42QP7DGSUOTSINQ2YLX33VGVANCNFSM6AAAAAA5D2HS2Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks! 🚀
I'm going to nitpick this on my end and alphabetize by the name
property 😄 but don't mind me, it's excellent either way.
@all-contributors please add @jaas666 for code.
|
I've put up a pull request to add @jaas666! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Adds @jaas666 as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#881 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Ahhh I should have thought of that.. Thanks |
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Added new
status: aged away
label