Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aged away label #881

Merged
merged 4 commits into from
Sep 23, 2023
Merged

feat: add aged away label #881

merged 4 commits into from
Sep 23, 2023

Conversation

jaas666
Copy link
Contributor

@jaas666 jaas666 commented Sep 23, 2023

PR Checklist

Overview

Added new status: aged away label

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #881 (6b08e38) into main (bfcd795) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   92.77%   92.78%           
=======================================
  Files          89       89           
  Lines        4636     4641    +5     
  Branches      355      355           
=======================================
+ Hits         4301     4306    +5     
  Misses        334      334           
  Partials        1        1           
Flag Coverage Δ
create 70.73% <100.00%> (+0.03%) ⬆️
initialize 35.60% <100.00%> (+0.07%) ⬆️
migrate 70.22% <100.00%> (+0.03%) ⬆️
unit 59.73% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...initializeGitHubRepository/labels/outcomeLabels.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks good, thanks! Just requesting changes on running the formatter.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Sep 23, 2023
@jaas666
Copy link
Contributor Author

jaas666 commented Sep 23, 2023 via email

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks! 🚀

I'm going to nitpick this on my end and alphabetize by the name property 😄 but don't mind me, it's excellent either way.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 565b854 into JoshuaKGoldberg:main Sep 23, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @jaas666 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @jaas666! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request Sep 23, 2023
Adds @jaas666 as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#881 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@jaas666
Copy link
Contributor Author

jaas666 commented Sep 23, 2023

Super, thanks! 🚀

I'm going to nitpick this on my end and alphabetize by the name property 😄 but don't mind me, it's excellent either way.

Ahhh I should have thought of that.. Thanks

@jaas666 jaas666 deleted the feat-aged-away-label branch September 23, 2023 22:34
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add a 'status: aged away' label
2 participants