Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split contributors option into exclude-all-contributors and --skip-all-contributors-api #899

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 29, 2023

PR Checklist

Overview

Splits the option into:

  • --exclude-all-contributors: disables the all-contributors feature altogether
  • --skip-all-contributors-api: allows the all-contributors feature, but skips fetching past contributions from GitHub

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #899 (3d343c5) into main (9696273) will increase coverage by 0.77%.
The diff coverage is 78.12%.

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   92.76%   93.54%   +0.77%     
==========================================
  Files          89       89              
  Lines        4674     4681       +7     
  Branches      358      367       +9     
==========================================
+ Hits         4336     4379      +43     
+ Misses        337      301      -36     
  Partials        1        1              
Flag Coverage Δ
create 72.29% <66.66%> (+1.45%) ⬆️
initialize 36.98% <43.33%> (+1.52%) ⬆️
migrate 71.09% <63.33%> (+0.88%) ⬆️
unit 66.02% <65.62%> (+6.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/initialize/initializeWithOptions.ts 87.30% <100.00%> (+7.93%) ⬆️
src/shared/options/args.ts 100.00% <100.00%> (ø)
src/shared/options/augmentOptionsWithExcludes.ts 71.98% <100.00%> (+0.43%) ⬆️
src/shared/options/optionsSchema.ts 100.00% <100.00%> (ø)
src/shared/options/readOptions.ts 92.69% <100.00%> (+0.03%) ⬆️
src/steps/finalizeDependencies.ts 100.00% <100.00%> (ø)
src/steps/writeReadme/generateTopContent.ts 100.00% <100.00%> (ø)
src/steps/writeReadme/index.ts 100.00% <100.00%> (ø)
src/steps/writing/creation/dotGitHub/index.ts 100.00% <100.00%> (ø)
src/create/createWithOptions.ts 69.11% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 29, 2023 14:20
@JoshuaKGoldberg JoshuaKGoldberg merged commit a51c624 into main Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the skip-all-contributors-api branch September 29, 2023 14:30
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant