Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Testing: Fill in unit test coverage for workflows.ts #875

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #899
Closed
3 tasks done

🧪 Testing: Fill in unit test coverage for workflows.ts #875

JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #899
Assignees
@JoshuaKGoldberg
Labels
area: testing Improving how the repository's tests are run and/or code is tested good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Splitting out of #869: the createWorkflows function inside dotGitHub is not currently unit tested. I'd love to see some unit tests added for it!

https://app.codecov.io/gh/JoshuaKGoldberg/create-typescript-app/blob/094b253411168038a2c7585e5172f8b773c18ea2/src%2Fsteps%2Fwriting%2Fcreation%2FdotGitHub%2Fworkflows.ts

For reference of similar unit tests, you can search for satisfies Options. Be sure to read the .github/DEVELOPMENT.md file for docs on how this repo can be worked on! 😉

Additional Info

Codecov reports that the function has some test coverage. That's because the function is run by the end-to-end tests. But there's not yet a workflows.test.ts file that unit tests its details.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 29, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 29, 2023
@JoshuaKGoldberg
feat: split contributors option into exclude-all-contributors and --s…
a51c624 
…kip-all-contributors-api (#899)

## PR Checklist

- [x] Addresses an existing open issue: fixes #875; fixes #898
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Splits the option into:

* `--exclude-all-contributors`: disables the all-contributors feature
altogether
* `--skip-all-contributors-api`: allows the all-contributors feature,
but skips fetching past contributions from GitHub
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: testing Improving how the repository's tests are run and/or code is tested good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg