-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base suggested next steps on options #906
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ | |
"tada", | ||
"tsup", | ||
"Unstaged", | ||
"wontfix" | ||
"wontfix", | ||
"vitest" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
183 changes: 183 additions & 0 deletions
183
src/shared/__snapshots__/generateNextSteps.test.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,183 @@ | ||
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":false,"excludeRenovate":false,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the GitHub apps: | ||
- Codecov (https://github.com/apps/codecov) | ||
- Renovate (https://github.com/apps/renovate)", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":false,"excludeRenovate":false,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Renovate GitHub app (https://github.com/apps/renovate).", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":false,"excludeRenovate":true,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Codecov GitHub app (https://github.com/apps/codecov).", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":false,"excludeRenovate":true,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":true,"excludeRenovate":false,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the GitHub apps: | ||
- Codecov (https://github.com/apps/codecov) | ||
- Renovate (https://github.com/apps/renovate)", | ||
"- populate the ACCESS_TOKEN secret (a GitHub PAT with repo and workflow permissions).", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":true,"excludeRenovate":false,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Renovate GitHub app (https://github.com/apps/renovate).", | ||
"- populate the ACCESS_TOKEN secret (a GitHub PAT with repo and workflow permissions).", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":true,"excludeRenovate":true,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Codecov GitHub app (https://github.com/apps/codecov).", | ||
"- populate the ACCESS_TOKEN secret (a GitHub PAT with repo and workflow permissions).", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":false,"excludeReleases":true,"excludeRenovate":true,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to populate the ACCESS_TOKEN secret (a GitHub PAT with repo and workflow permissions).", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":false,"excludeRenovate":false,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the GitHub apps: | ||
- Codecov (https://github.com/apps/codecov) | ||
- Renovate (https://github.com/apps/renovate)", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":false,"excludeRenovate":false,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Renovate GitHub app (https://github.com/apps/renovate).", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":false,"excludeRenovate":true,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to:", | ||
"lines": [ | ||
"- enable the Codecov GitHub app (https://github.com/apps/codecov).", | ||
"- populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
], | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":false,"excludeRenovate":true,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to populate the secrets: | ||
- ACCESS_TOKEN (a GitHub PAT with repo and workflow permissions) | ||
- NPM_TOKEN (an npm access token with automation permissions)", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":true,"excludeRenovate":false,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to enable the GitHub apps: | ||
- Codecov (https://github.com/apps/codecov) | ||
- Renovate (https://github.com/apps/renovate)", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":true,"excludeRenovate":false,"excludeTests":true} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to enable the Renovate GitHub app (https://github.com/apps/renovate).", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":true,"excludeRenovate":true,"excludeTests":false} 1`] = ` | ||
[ | ||
{ | ||
"label": "Be sure to enable the Codecov GitHub app (https://github.com/apps/codecov).", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`generateNextSteps > {"excludeAllContributors":true,"excludeReleases":true,"excludeRenovate":true,"excludeTests":true} 1`] = `[]`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { describe, expect, test } from "vitest"; | ||
|
||
import { generateNextSteps } from "./generateNextSteps.js"; | ||
import { Options } from "./types.js"; | ||
|
||
const options = { | ||
access: "public", | ||
base: "everything", | ||
description: "Test description.", | ||
email: { | ||
github: "[email protected]", | ||
npm: "[email protected]", | ||
}, | ||
logo: undefined, | ||
mode: "create", | ||
owner: "TestOwner", | ||
repository: "test-repository", | ||
title: "Test Title", | ||
} satisfies Options; | ||
|
||
describe("generateNextSteps", () => { | ||
for (const excludeAllContributors of [false, true]) { | ||
for (const excludeReleases of [false, true]) { | ||
for (const excludeRenovate of [false, true]) { | ||
for (const excludeTests of [false, true]) { | ||
test( | ||
// eslint-disable-next-line vitest/valid-title | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
JSON.stringify({ | ||
excludeAllContributors, | ||
excludeReleases, | ||
excludeRenovate, | ||
excludeTests, | ||
}), | ||
() => { | ||
expect( | ||
generateNextSteps({ | ||
...options, | ||
excludeAllContributors, | ||
excludeReleases, | ||
excludeRenovate, | ||
excludeTests, | ||
}), | ||
).toMatchSnapshot(); | ||
}, | ||
); | ||
} | ||
} | ||
} | ||
} | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that I can use
booleanValue || somethingMoreComplex
in the new function.