Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip file cleanup if installation is skipped #975

Conversation

GV14982
Copy link
Contributor

@GV14982 GV14982 commented Oct 20, 2023

PR Checklist

Overview

Moved the "Cleaning up files" runCommand call inside of the preceding conditional to only run if packages were installed.

For some reason my terminal won't let me put in emojis, so I'll use <(-.-)>

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #975 (6b368f9) into main (a13ac6a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files          91       91           
  Lines        4860     4860           
  Branches      403      403           
=======================================
  Hits         4543     4543           
  Misses        316      316           
  Partials        1        1           
Flag Coverage Δ
create 71.10% <100.00%> (ø)
initialize 38.29% <0.00%> (ø)
migrate 69.95% <0.00%> (ø)
unit 68.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/create/createWithOptions.ts 73.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfect, thanks!

The migration script failure in CI is unrelated and caused by #877.

2023-10-20T16:52:37.0145387Z Stdout from running `git diff HEAD -- .nvmrc`:
2023-10-20T16:52:37.0146190Z diff --git a/.nvmrc b/.nvmrc
2023-10-20T16:52:37.0146744Z index 6569dfa..3d32543 100644
2023-10-20T16:52:37.0147270Z --- a/.nvmrc
2023-10-20T16:52:37.0147585Z 
2023-10-20T16:52:37.0147717Z +++ b/.nvmrc
2023-10-20T16:52:37.0148412Z Oh no! Running the migrate script modified some files:
2023-10-20T16:52:37.0149109Z  - .nvmrc
2023-10-20T16:52:37.0149367Z 
2023-10-20T16:52:37.0149850Z That likely indicates changes made to the repository without
2023-10-20T16:52:37.0150509Z @@ -1 +1 @@
2023-10-20T16:52:37.0151041Z corresponding updates to templates in src/.
2023-10-20T16:52:37.0151503Z 
2023-10-20T16:52:37.0152064Z Please search for those file(s)' name(s) under src/migrate for
2023-10-20T16:52:37.0152887Z the corresponding template and update those as well.
2023-10-20T16:52:37.0153486Z -20.8.1
2023-10-20T16:52:37.0153868Z +20.8.0

@JoshuaKGoldberg
Copy link
Owner

For some reason my terminal won't let me put in emojis, so I'll use <(-.-)>

Haha, I appreciate you doing your best either way!

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @GV14982 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @GV14982! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

🎉 This is included in version v1.39.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Oct 20, 2023
Adds @GV14982 as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#975 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Skip "Cleaning up files" if options.skipInstall is true
2 participants