-
Notifications
You must be signed in to change notification settings - Fork 114
Convert double to int to fix floating point comparison #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- This comparison `guest.center.dx == host.width / 2` could fail as each double can end up with different number of decimal places
Hi @vizhan-lanars @LanarsInc can I get your review on this PR :) |
@franciscrispin Could you provide code or steps to reproduce that exception? |
I'm experiencing this issue with the iPhone 15 and above. I'm using Flutter Steps to reproduce:
======== Exception caught by rendering library ===================================================== When the exception was thrown, this was the stack:
|
The
GapLocationException
could be mistakenly thrown when comparingguest.center.dx == host.width / 2
as both values are doubles. This led to the navigation bar showing up as a blank state. Refer to the screen recording and screen shots attached for reference.21-08-18-13-22-42.1.mp4