Skip to content

Mark trainer.callback_connector as protected #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2021
Merged

Mark trainer.callback_connector as protected #10121

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e77c9a9
mark callback_connector as protected
daniellepintz Oct 25, 2021
bd3ab12
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Oct 25, 2021
7b10f61
Merge branch 'master' into callback_con
carmocca Oct 26, 2021
02d17a5
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Oct 26, 2021
df07106
Merge branch 'callback_con' of github.com:daniellepintz/pytorch-light…
daniellepintz Oct 26, 2021
65d7055
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pytorch_lightning/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ def __init__(
)
self.logger_connector = LoggerConnector(self, log_gpu_memory)
self.model_connector = ModelConnector(self)
self.callback_connector = CallbackConnector(self)
self._callback_connector = CallbackConnector(self)
self.debugging_connector = DebuggingConnector(self)
self.training_tricks_connector = TrainingTricksConnector(self)
self.checkpoint_connector = CheckpointConnector(self, resume_from_checkpoint)
Expand Down Expand Up @@ -496,8 +496,8 @@ def __init__(
self._weights_summary: Optional[str] = None

# init callbacks
# Declare attributes to be set in callback_connector on_trainer_init
self.callback_connector.on_trainer_init(
# Declare attributes to be set in _callback_connector on_trainer_init
self._callback_connector.on_trainer_init(
callbacks,
checkpoint_callback,
enable_checkpointing,
Expand Down Expand Up @@ -1031,14 +1031,14 @@ def _run(
verify_loop_configurations(self, model)

# attach model log function to callback
self.callback_connector.attach_model_logging_functions(model)
self._callback_connector.attach_model_logging_functions(model)

# attach model to the training type plugin
self.training_type_plugin.connect(model)

# hook
self._data_connector.prepare_data()
self.callback_connector._attach_model_callbacks()
self._callback_connector._attach_model_callbacks()

# ----------------------------
# SET UP TRAINING
Expand Down