Skip to content

Mark trainer.callback_connector as protected #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2021

Conversation

daniellepintz
Copy link
Contributor

What does this PR do?

Part of #9778

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz changed the title Mark callback_connector as protected Mark trainer.callback_connector as protected Oct 25, 2021
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10121 (bd3ab12) into master (93266e2) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head bd3ab12 differs from pull request most recent head 7b10f61. Consider uploading reports for the commit 7b10f61 to get more accurate results

@@           Coverage Diff           @@
##           master   #10121   +/-   ##
=======================================
  Coverage      89%      89%           
=======================================
  Files         180      182    +2     
  Lines       16151    16149    -2     
=======================================
- Hits        14324    14323    -1     
+ Misses       1827     1826    -1     

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 26, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 26, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2021
@mergify mergify bot requested a review from a team October 26, 2021 09:51
@mergify mergify bot removed the has conflicts label Oct 26, 2021
@carmocca carmocca enabled auto-merge (squash) October 26, 2021 12:38
@carmocca carmocca merged commit c211adb into Lightning-AI:master Oct 29, 2021
@daniellepintz daniellepintz deleted the callback_con branch October 29, 2021 17:40
@rohitgr7 rohitgr7 mentioned this pull request Jan 17, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants