Skip to content

Run Verify Issue linking workflow only when label is bug or enhancement #10236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Run Verify Issue linking workflow only when label is bug or enhancement #10236

wants to merge 2 commits into from

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Run Verify Issue linking workflow only when PR label is bug or enhancement

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the bug Something isn't working label Oct 29, 2021
@kaushikb11 kaushikb11 added feature Is an improvement or enhancement and removed bug Something isn't working labels Oct 29, 2021
@kaushikb11 kaushikb11 marked this pull request as draft October 29, 2021 07:52
@kaushikb11 kaushikb11 marked this pull request as ready for review October 29, 2021 08:03
@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@mergify mergify bot requested a review from a team October 29, 2021 09:26
awaelchli
awaelchli approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just do what I always do. Add this to your PR template:

image

😅

@kaushikb11 kaushikb11 marked this pull request as draft October 29, 2021 11:55
@rohitgr7
Copy link
Contributor

Or just do what I always do. Add this to your PR template:

image

sweat_smile

hackerman

rohitgr7
rohitgr7 reviewed Oct 30, 2021
View reviewed changes
.github/workflows/ci_verify_pr_contains_issue.yaml
@@ -10,7 +10,7 @@ jobs:
verify_linked_issue:
runs-on: ubuntu-latest
name: Ensure Pull Request has a linked issue.
if: github.event.pull_request.draft == false
if: github.event.pull_request.draft == false and github.event.label.name == 'enhancement'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enhancement will cover up bugfix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naa, It's still Draft and testing it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay! I saw everyone approved so thought maybe it's ready 😄

@tchaton tchaton added this to the v1.6.x milestone Nov 1, 2021
@awaelchli awaelchli modified the milestones: v1.6.x, 1.5.x Nov 3, 2021
@tchaton
Copy link
Contributor

tchaton commented Nov 8, 2021

Hey @kaushikb11.

The simplest would be to fork the initial repo and add our own logic there. We could add this only for us and F.

Best,
T.C

@carmocca
Copy link
Contributor

carmocca commented Nov 8, 2021

I can work on our bot fork. But I'd advocate for removing the integration until it is done.

@Borda
Copy link
Member

Borda commented Nov 22, 2021

@kaushikb11 still a draft? :]

@carmocca carmocca mentioned this pull request Jan 6, 2022
Merged
8 tasks
@carmocca carmocca deleted the update/issue_link_workflow branch January 6, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 left review comments

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

Assignees
No one assigned
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
7 participants
@kaushikb11 @rohitgr7 @tchaton @carmocca @Borda @awaelchli @justusschock