Skip to content

Remove the "Verify linked issue" bot #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 6, 2022

What does this PR do?

Removes the "Verify linked issue" bot. The bot has too many false positives and false negatives. Some contributors have resorted to "fake" linked issues in their PRs to avoid the message spam and error mark.

We need a better solution, either by extending its implementation or finding a different bot. At the moment, the simplest option is to remove the noise.

Opens #9397
Closes #10236

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Jan 6, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 6, 2022
@carmocca carmocca requested review from Borda and tchaton as code owners January 6, 2022 02:52
@carmocca carmocca self-assigned this Jan 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 6, 2022
@mergify mergify bot requested a review from a team January 6, 2022 05:31
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@akihironitta akihironitta merged commit f6a6a25 into master Jan 6, 2022
@akihironitta akihironitta deleted the ci/remove-verify-bot branch January 6, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants