Skip to content

Mark SignalConnector as protected #11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Mark SignalConnector as protected #11513

merged 3 commits into from
Jan 20, 2022

Conversation

Cyber-Machine
Copy link
Contributor

What does this PR do?

Fixes #11483

Does your PR introduce any breaking changes? If yes, please list them.

NONE

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes .
Make sure you had fun coding 🙃

@rohitgr7
Copy link
Contributor

hey @Cyber-Machine !

thanks for the PR.
Check out this #10121 for reference. The class will stay as it is.

@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 17, 2022
@rohitgr7 rohitgr7 added design Includes a design discussion refactor labels Jan 17, 2022
@Cyber-Machine
Copy link
Contributor Author

hey @Cyber-Machine !

thanks for the PR. Check out this #10121 for reference. The class will stay as it is.

Thanks for feedback! I have implemented the changes according to the reference. 😄

@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 merged commit 16a04b2 into Lightning-AI:master Jan 20, 2022
@Cyber-Machine Cyber-Machine deleted the signalconnector branch January 20, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark SignalConnector as protected:
6 participants