-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove use of jsonargparse internals #12918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
otaj
merged 3 commits into
Lightning-AI:master
from
mauvilsa:cli-remove-import_docstring_parse
Apr 29, 2022
Merged
Remove use of jsonargparse internals #12918
otaj
merged 3 commits into
Lightning-AI:master
from
mauvilsa:cli-remove-import_docstring_parse
Apr 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
approved these changes
Apr 28, 2022
Borda
approved these changes
Apr 28, 2022
otaj
reviewed
Apr 28, 2022
otaj
approved these changes
Apr 28, 2022
otaj
reviewed
Apr 28, 2022
rohitgr7
reviewed
Apr 28, 2022
akihironitta
approved these changes
Apr 28, 2022
kaushikb11
approved these changes
Apr 29, 2022
carmocca
pushed a commit
that referenced
this pull request
May 2, 2022
carmocca
pushed a commit
that referenced
this pull request
May 3, 2022
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
import_docstring_parse
function is not part of the jsonargparse public API, see https://jsonargparse.readthedocs.io/en/stable/#api-reference. This pull request removes its use to avoid possible failures due to changes in jsonargparse internals. An example of this happening can be seen in #12884 (comment).I think this change should be included in 1.6.X. Even though
import_docstring_parse
is internal, I will change it again to be backward compatible so that released versions ofLightningCLI
do not fail due to this, see jsonargparse/commit/6dc8539.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃