Skip to content

Improved the jsonargparse[signatures] availability variable #13035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2022
Merged

Improved the jsonargparse[signatures] availability variable #13035

merged 10 commits into from
May 12, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented May 11, 2022

What does this PR do?

This PR addresses #12918 (comment). Also saw #11826 so I moved the code to cli.py.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.7 milestone May 11, 2022
@carmocca carmocca added refactor lightningcli pl.cli.LightningCLI community This PR is from the community labels May 11, 2022
@carmocca carmocca self-assigned this May 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 11, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@carmocca carmocca enabled auto-merge (squash) May 12, 2022 14:42
@carmocca carmocca merged commit 8713e0e into Lightning-AI:master May 12, 2022
@mauvilsa mauvilsa deleted the cli-requirement-available branch May 12, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community lightningcli pl.cli.LightningCLI ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants