Skip to content

store: adding group-check #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

store: adding group-check #16528

merged 2 commits into from
Jan 27, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 27, 2023

What does this PR do?

resolves: #15811 (comment)
@carmocca do you have any suggestions for codeowners?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@Borda Borda enabled auto-merge (squash) January 27, 2023 13:34
@github-actions github-actions bot added the ci Continuous Integration label Jan 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning: Store
Check ID Status
Store.cloud (test_store Linux) success
Store.cloud (test_store Mac) success
Store.cloud (test_store Windows) success

These checks are required after the changes to .azure/app-cloud-store.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda merged commit c8c4722 into master Jan 27, 2023
@Borda Borda deleted the store/gc branch January 27, 2023 14:01
@mergify mergify bot added the ready PRs ready to be merged label Jan 27, 2023
@awaelchli awaelchli added this to the 2.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants