-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Init: Models store API #15811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Init: Models store API #15811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
371dc02
to
71b1da5
Compare
71b1da5
to
1ace2d0
Compare
eae6502
to
3a820d7
Compare
justusschock
approved these changes
Jan 26, 2023
ethanwharris
approved these changes
Jan 26, 2023
awaelchli
approved these changes
Jan 26, 2023
Co-authored-by: Adrian Wälchli <[email protected]>
Borda
approved these changes
Jan 26, 2023
lantiga
reviewed
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
for more information, see https://pre-commit.ci
12 tasks
Can you add CODEOWNERS and update checkgroup with this? |
not sure who shall be code-owner, so let's keep default for now |
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
ci
Continuous Integration
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adding uploading to cloud...
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
known limitations
list
ordelete
some models...Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @akihironitta