Skip to content

Init: Models store API #15811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Jan 27, 2023
Merged

Init: Models store API #15811

merged 51 commits into from
Jan 27, 2023

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Nov 25, 2022

What does this PR do?

adding uploading to cloud...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

known limitations

  • missing UI, so a user may not see what models he already has
  • missing CLI for list or delete some models...

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success
app-pytest (macOS-11, app, 3.8, oldest) success
app-pytest (macOS-11, lightning, 3.9, latest) success
app-pytest (ubuntu-20.04, app, 3.8, latest) success
app-pytest (ubuntu-20.04, app, 3.8, oldest) success
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.8, oldest) success
app-pytest (windows-2022, lightning, 3.8, latest) success

These checks are required after the changes to src/lightning_app/core/constants.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success
app-examples (macOS-11, app, 3.9, oldest) success
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (ubuntu-20.04, app, 3.9, oldest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (windows-2022, app, 3.9, latest) success
app-examples (windows-2022, app, 3.9, oldest) success
app-examples (windows-2022, lightning, 3.9, latest) success

These checks are required after the changes to src/lightning_app/core/constants.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success

These checks are required after the changes to .azure/app-cloud-e2e.yml, src/lightning_app/core/constants.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success
make-html (app) success

These checks are required after the changes to src/lightning_app/core/constants.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/store/__init__.py, src/lightning/store/authentication.py, src/lightning/store/cloud_api.py, src/lightning/store/save.py, src/lightning/store/utils.py, src/lightning_app/core/constants.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.7) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.7) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.7) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/store/__init__.py, src/lightning/store/authentication.py, src/lightning/store/cloud_api.py, src/lightning/store/save.py, src/lightning/store/utils.py, src/lightning_app/core/constants.py.

🟢 link-check
Check ID Status
markdown-link-check success

These checks are required after the changes to src/lightning/store/README.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@krshrimali krshrimali marked this pull request as draft November 25, 2022 03:20
@Borda Borda self-assigned this Dec 4, 2022
@Borda Borda added this to the v1.8.x milestone Dec 4, 2022
@Borda Borda marked this pull request as ready for review December 13, 2022 13:30
@Borda Borda requested a review from williamFalcon as a code owner December 30, 2022 14:00
@Borda Borda modified the milestones: v1.8.x, v1.9 Jan 6, 2023
@Borda Borda modified the milestones: v1.9, future Jan 16, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jan 26, 2023
@Borda Borda enabled auto-merge (squash) January 26, 2023 11:06
@Borda Borda disabled auto-merge January 26, 2023 14:01
@Borda Borda enabled auto-merge (squash) January 26, 2023 14:04
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@Borda Borda requested a review from lantiga January 26, 2023 16:43
@Borda Borda merged commit d738ab1 into master Jan 27, 2023
@Borda Borda deleted the feat/model2cloud branch January 27, 2023 11:27
@Borda Borda mentioned this pull request Jan 27, 2023
12 tasks
@carmocca
Copy link
Contributor

Can you add CODEOWNERS and update checkgroup with this?

@Borda
Copy link
Member

Borda commented Jan 27, 2023

Can you add CODEOWNERS and update checkgroup with this?

not sure who shall be code-owner, so let's keep default for now
and yes, adding group-check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants