Skip to content

store: update API in messages #16535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 30, 2023
Merged

store: update API in messages #16535

merged 8 commits into from
Jan 30, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 27, 2023

What does this PR do?

leftover after the last API rename in #15811

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda requested a review from a team January 27, 2023 19:02
@Borda Borda enabled auto-merge (squash) January 28, 2023 02:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning: Store
Check ID Status
Store.cloud (test_store Linux) success
Store.cloud (test_store Mac) success
Store.cloud (test_store Windows) success

These checks are required after the changes to src/lightning/store/README.md, src/lightning/store/__init__.py, src/lightning/store/cloud_api.py, src/lightning/store/utils.py, tests/tests_cloud/test_model.py, tests/tests_cloud/test_requirements.py, tests/tests_cloud/test_source_code.py, tests/tests_cloud/test_versioning.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/store/__init__.py, src/lightning/store/cloud_api.py, src/lightning/store/utils.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.7) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.7) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.7) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.7) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.7) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.7) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/store/__init__.py, src/lightning/store/cloud_api.py, src/lightning/store/utils.py.

🟢 link-check
Check ID Status
markdown-link-check success

These checks are required after the changes to src/lightning/store/README.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming seems asymmetric.
upload_to_cloud
but
load_model

@Borda
Copy link
Member Author

Borda commented Jan 30, 2023

the naming seems asymmetric. upload_to_cloud but load_model

renamed to upload_model

@Borda Borda requested review from ethanwharris and a team January 30, 2023 01:02
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Jan 30, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jan 30, 2023
@Borda Borda merged commit dc38663 into master Jan 30, 2023
@Borda Borda deleted the store/names branch January 30, 2023 11:19
@awaelchli awaelchli added this to the 2.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants