-
Notifications
You must be signed in to change notification settings - Fork 3.5k
typing trainer.connectors.checkpoint connector
#9419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carmocca
merged 17 commits into
Lightning-AI:master
from
jjenniferdai:typing-checkpoint-connector
Sep 15, 2021
Merged
typing trainer.connectors.checkpoint connector
#9419
carmocca
merged 17 commits into
Lightning-AI:master
from
jjenniferdai:typing-checkpoint-connector
Sep 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
reviewed
Sep 9, 2021
tchaton
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fyi some overlap between this and #9434 |
trainer.connectors.checkpoint connector
trainer.connectors.checkpoint connector
ananthsub
approved these changes
Sep 10, 2021
awaelchli
reviewed
Sep 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #9419 +/- ##
======================================
Coverage 89% 89%
======================================
Files 180 180
Lines 15102 15106 +4
======================================
+ Hits 13414 13418 +4
Misses 1688 1688 |
kaushikb11
approved these changes
Sep 14, 2021
ananthsub
reviewed
Sep 14, 2021
awaelchli
approved these changes
Sep 14, 2021
ananthsub
reviewed
Sep 14, 2021
Co-authored-by: ananthsub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
part of #5023, finish typing for
trainer.connectors.checkpoint connector
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃