refactoring methods in catalog_controller_spec.rb #3885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq_bot add_label rbac |
|
@miq-bot add_label wip |
|
@VratislavHais please, change the title, so it describes the change you are doing in the PR |
|
code review: @oslegl |
romanblanco
reviewed
May 5, 2018
| allow(controller).to receive(:find_checked_items).and_return(ServiceTemplate.all.ids) | ||
| allow(controller).to receive(:tag_edit_build_entries_pulldown).and_return(nil) | ||
| allow(controller).to receive(:replace_right_cell).with(:action => nil) | ||
| controller.send(:x_edit_tags_reset, "ServiceTemplate") |
There was a problem hiding this comment.
@VratislavHais expected behaviour is missing here
|
travis failed on a different file. Can you please restart it? |
|
close/open PR to restart it. |
romanblanco
reviewed
May 10, 2018
| controller.instance_variable_set(:@_params, {}) # affects params in controller | ||
| controller.instance_variable_set(:@sb, :action => nil) | ||
| allow(controller).to receive(:checked_or_params).and_return(ServiceTemplate.all.ids) | ||
| allow(controller).to receive(:find_checked_items).and_return(ServiceTemplate.all.ids) |
There was a problem hiding this comment.
this line shouldn't be necessary, as you're already mocking checked_or_params.
(same as https://github.com/ManageIQ/manageiq-ui-classic/pull/3891/files#r187269347)
|
Checked commit VratislavHais@294a8ea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #1134