Update "Order undefined error" branch to [email protected] #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer static method to bound instance.
Rebase typo fixes from @kiurchv.
Add environment variable to select cases and log generated configs.
Nix the `extract` query parameter to `loader.js`. It appears either bugged or no longer used. As of f7d5bbf it only ever got set to `true` or `undefined` and checked `query !== false` which could only ever pass. I made the faulty assumption that `false` would execute the same path as `undefined` which broke tests. @sokra PLEASE review this?
Wrap args in options object.
Maintains return type of `extract` for backwards compatibility with `loader` configs but delegates to `extractAll` for use with `loaders` array to support WebPack 2 query objects.
`JSON.stringify` any query objects in `extract`.
Fix webpack-contrib#168. Close webpack-contrib#157. Close webpack-contrib#195.
This reverts commit a9fa35b. # Conflicts: # index.js > You could always flatten the query objects and omit extractAll. There is no benefit from keeping the query objects intact. webpack stringifies them anyway. btw. in webpack 2 loader and loaders do the same. Both accept an array or a string. @sokra in https://gitter.im/webpack/webpack/developer?at=5763aed963ea0987306be32d Nix `extractAll` and add `getLoaderWithQuery`.
Reported by @kentcdodds CC @ianks.
…xtract-text-webpack-plugin into jane-196-webpack2-query-object # Conflicts: # package.json
…pack-plugin into doctolib-master # Conflicts: # index.js # loader.js # test/TestCases.test.js
fixes webpack-contrib#182 Maybe fixes webpack-contrib#106
Link to v1's documentation from v2's README
This is not actually API-compatible with any webpack beta older than 2.1.0-beta.19.
Fix handling of loaders as objects without a query prop
Be more specific on the peerDependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the
order-undefined-branchagainst the latestmasterof the upstream repo.It includes breaking changes (hence the alternate
-2branch name) but I think it's important for visibility to add a PR to this repo.