Debug adapters can notify VSCode about out-of-band line breakpoints but not command breakpoints #223
Labels
feature-request
Request for new features or functionality
Comments
|
This is missing. |
rkeithhill
referenced
this issue
in PowerShell/PowerShellEditorServices
Feb 16, 2018
Fixex PowerShell/vscode-powershell#1159 When VSCode passes us a breakpoint to set, we normally set a flag to indicate "setBreakpointInProgress" so that when the DebugService_BreakpointUpdated event is fired, we can tell that we initiated it instead of the user using Set-PSBreakpoint to set a breakpoint. Well, the code that handled function breakpoints msgs sent by VSCode was not setting that flag. Also, when the user does use Set-PSBreakpoint -Command there is no debug protocol event for function breakpoints so we need to ignore this type of breakpoint set by the user until the debug protocol support it. See https://github.com/Microsoft/vscode-debugadapter-node/issues/157
rkeithhill
referenced
this issue
in PowerShell/PowerShellEditorServices
Feb 20, 2018
* Fix PSES crash on debug start when function breakpoint defined Fixex PowerShell/vscode-powershell#1159 When VSCode passes us a breakpoint to set, we normally set a flag to indicate "setBreakpointInProgress" so that when the DebugService_BreakpointUpdated event is fired, we can tell that we initiated it instead of the user using Set-PSBreakpoint to set a breakpoint. Well, the code that handled function breakpoints msgs sent by VSCode was not setting that flag. Also, when the user does use Set-PSBreakpoint -Command there is no debug protocol event for function breakpoints so we need to ignore this type of breakpoint set by the user until the debug protocol support it. See https://github.com/Microsoft/vscode-debugadapter-node/issues/157 * Add comment on why code is commented out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I work on the PowerShell debug adapter and that adapter provides a REPL while debugging. In the PowerShell Integrated Console during debugging, a user can use a PowerShell command
Set-PSBreakpointto set both line and function breakpoints. On the line breakpoints we can use the BreakpointEvent to communicate this back to VSCode;https://github.com/Microsoft/vscode-debugadapter-node/blob/b61cf04501cfe7356b695f99bc60961684f89a4f/protocol/src/debugProtocol.ts#L179-L189
However I'm not finding an equivalent event for function breakpoints. What am I missing? Or is this missing from the debug protocol?
The text was updated successfully, but these errors were encountered: