Fix PSES crash on debug start when function breakpoint defined #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixex PowerShell/vscode-powershell#1159 When VSCode passes us a breakpoint to set, we normally set a flag to indicate "setBreakpointInProgress" so that when the DebugService_BreakpointUpdated event is fired, we can tell that we initiated it instead of the user using Set-PSBreakpoint to set a breakpoint. Well, the code that handled function breakpoints msgs sent by VSCode was not setting that flag. Also, when the user does use Set-PSBreakpoint -Command there is no debug protocol event for function breakpoints so we need to ignore this type of breakpoint set by the user until the debug protocol support it. See https://github.com/Microsoft/vscode-debugadapter-node/issues/157
|
Hmm, all the Microsoft.PowerShell.EditorServices.Test.dll tests pass on my machine: |
|
AppVeyor likes to throw a fit every once in a while. We're good now :) |
TylerLeonhardt
approved these changes
Feb 16, 2018
|
|
||
| // try | ||
| // { | ||
| // // Set exception breakpoints in DebugService |
There was a problem hiding this comment.
Any reason we need this commented out code? If so, can you supply a reason in the comment?
There was a problem hiding this comment.
I'm hoping we will eventually get support for breaking on unhandled exceptions (maybe even first thrown). When we do, I don't want to have the same mistake of not setting the setBreakpointInProgress flag. That was the one of the causes of the crash. I can add a comment along those lines.
|
@tylerl0706 Can you kick the appveyor build? |
|
kicked ⚽ |
daviwil
approved these changes
Feb 20, 2018
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Add version update notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixex PowerShell/vscode-powershell#1159
When VSCode passes us a breakpoint to set, we normally set
a flag to indicate "setBreakpointInProgress" so that when
the DebugService_BreakpointUpdated event is fired, we can
tell that we initiated it instead of the user using Set-PSBreakpoint
to set a breakpoint. Well, the code that handled function
breakpoints msgs sent by VSCode was not setting that flag.
Also, when the user does use Set-PSBreakpoint -Command
there is no debug protocol event for function breakpoints
so we need to ignore this type of breakpoint set by the user
until the debug protocol support it.
See https://github.com/Microsoft/vscode-debugadapter-node/issues/157