-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests with YAML metaschemas #4137
Run tests with YAML metaschemas #4137
Conversation
…om/ralfhandl/OpenAPI-Specification into schemas-yaml-to-json-test-check-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
One minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still prefer to not have the JSON on main
at all. I think the problem of "these schemas look published but they are not" is the bigger problem here, and I don't think we should invest in the current arrangement.
Per #3677, I think we should focus on setting up schema development correctly on the new dev
branch (and release-line-specific branches off of it), which is where all work-in-progress will live.
If there's an argument that this is a necessary step, I'm open to it, but this feels like going backwards to me by trying to bless main
as an alternate publication location.
The JSON is used by the schema tests on
In addition we can remove the JSON from
Fine with me, but the schema tests being based on the JSON contradicts the README's claim that the YAML are is leading, and fixing that now makes it easier to move the sources & scripts somewhere else. |
The schema-test workflow was using the JSON metaschemas, whereas the README.md files claim that the YAML files are the source of truth.
validate.mjs