chore: bring back json schemas to avoid a breaking change in schemastore and other third parties #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore and other third parties
ralfhandl
reviewed
Oct 21, 2024
There was a problem hiding this comment.
This file was intentionally deleted, please use this URL
ralfhandl
reviewed
Oct 21, 2024
There was a problem hiding this comment.
This file was intentionally deleted, please use this URL
ralfhandl
reviewed
Oct 21, 2024
There was a problem hiding this comment.
This file was intentionally deleted, please use this URL
ralfhandl
requested changes
Oct 21, 2024
There was a problem hiding this comment.
This file was intentionally deleted, please use this URL
lornajane
approved these changes
Oct 21, 2024
|
Schemastore, when updated, should automatically fix everything within a few days as the TTL is relatively low. I'm in favour of closing this PR. |
|
Closing this based on SchemaStore/schemastore#4159 fixing this in a safer way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4149
Reverts a section of #4137 for reasons stated in #4149