Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Google Tag Manager #4403

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 4, 2025

Apparently the respec build interferes with how Google Tag Manager (GTM) works. This is an attempt to fix that:

Preview of output

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

- move script as far up as possible
- remove GTM stuff added by respec build
@ralfhandl ralfhandl requested review from a team as code owners March 4, 2025 11:01
@ralfhandl ralfhandl changed the title Google Tag Manager Repair Google Tag Manager Mar 4, 2025
@lornajane
Copy link
Contributor

Can we provide sample output so that people can compare with the currently-broken version? I think it would be easier to get feedback from the outreach people if we did.

@baywet
Copy link
Contributor

baywet commented Mar 13, 2025

@handrews to ask Diane to review the correctness of google analytics

@handrews handrews merged commit 7f5e1cf into OAI:main Mar 14, 2025
2 checks passed
@ralfhandl ralfhandl deleted the main-move-up-google-analytics branch March 14, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants