Skip to content

DartClientCodegen reads dart-keywords.txt as resource, not file #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

roxspring
Copy link
Contributor

@roxspring roxspring commented Nov 13, 2019

#4449 introduced a dependency on to a relative file location and means that ./bin/run-all-petstore produces error messages when used. I've switched this to load as a resource from the classpath instead.

@nickmeinhold, @wing328 were involved in the original MR and are probably best to review.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Nov 14, 2019

@roxspring thanks for the PR. Agreed the file should be read as a resource instead.

@wing328 wing328 added this to the 4.2.1 milestone Nov 14, 2019
@roxspring roxspring marked this pull request as ready for review November 14, 2019 10:04
@nickmeinhold
Copy link
Contributor

Thanks for the fix @roxspring! Sorry for causing the problem.

@wing328 wing328 merged commit b43785a into OpenAPITools:master Nov 14, 2019
@roxspring roxspring deleted the feature/gh-4449-dart-keywords-as-resource branch November 15, 2019 10:02
@wing328
Copy link
Member

wing328 commented Nov 15, 2019

@roxspring thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants