Skip to content

Update samples against master code #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

roxspring
Copy link
Contributor

Building on #4484, and in preparation for #4454, I've run ./bin/run-all-petstore to bring the samples up to date.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@roxspring
Copy link
Contributor Author

roxspring commented Nov 14, 2019

I'm still seeing that the samples are out of date, and make it very difficult to propose/review a MR which modifies the samples further. I've taken recent branch (+ #4484 fix for dart generator) and rebuilt the samples (using bin/run-all-petstore) but CI is failing:

@wing328 @jimschubert any recommendations on how I should move forward?

@roxspring roxspring force-pushed the feature/multi-level-model-hierarchy-prep branch from 98fbfce to 9952c41 Compare November 15, 2019 23:13
@jimschubert
Copy link
Member

@OpenAPITools/generator-core-team we should probably consider adding this as a release step. Any thoughts on that?

@roxspring roxspring closed this Dec 27, 2019
@roxspring roxspring deleted the feature/multi-level-model-hierarchy-prep branch December 27, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants