Skip to content

Enhancement/kotlin/retrofit2 #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Enhancement/kotlin/retrofit2 #5697

wants to merge 19 commits into from

Conversation

ch4rl3x
Copy link
Contributor

@ch4rl3x ch4rl3x commented Mar 24, 2020

#5076

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

PR Description

This PR add the option to use koltin suspend functions combined with retrofit2. Also adds more complexity (authorization) and ability to customization to the ApiClient.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu

@auto-labeler
Copy link

auto-labeler bot commented Mar 24, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@ch4rl3x
Copy link
Contributor Author

ch4rl3x commented Mar 25, 2020

@4brunu you was right. I checked it again, was my fault. moshiBuilder/gsonBuilder as lazy is not neccessary. I changed it also back to val instead of var, like before

@4brunu
Copy link
Contributor

4brunu commented Mar 25, 2020

The PR ir really big, and a bit difficult to review.
Would it be possible to split it into smaller parts?

@ch4rl3x
Copy link
Contributor Author

ch4rl3x commented Mar 25, 2020

Thats a good question. The kotlin-retrofit2 library was too simple. We tooked most parts from java-retrofit2. Because of that, its such a big PR

@4brunu
Copy link
Contributor

4brunu commented Mar 26, 2020

I saw that you changed the path of all the sample projects, and I think that's whats causing some many files being changed.
Could you please submit that change in a different PR please?

@ch4rl3x
Copy link
Contributor Author

ch4rl3x commented Mar 26, 2020

Ok, so do i have to close these PR and create a clean, new one?

@4brunu
Copy link
Contributor

4brunu commented Mar 26, 2020

No, you can keep this one open.
Just create a new one with the only the current sample projects being moved around.
When the new one get's merged, the diff in this PR vs the master branch will be much smaller.

@ch4rl3x
Copy link
Contributor Author

ch4rl3x commented May 11, 2020

@wing328 I will make a new/simpler PR without renaming etc

@wing328
Copy link
Member

wing328 commented May 20, 2020

@ch4rl3x FYI. #5750 has been merged into master.

Shall we close this PR?

@ch4rl3x
Copy link
Contributor Author

ch4rl3x commented May 27, 2020

I will make a new PR within the next few weeks hopefully

@ch4rl3x ch4rl3x closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants