-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Enhancement/kotlin/retrofit2 #5697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/kotlin/retrofit2 #5697
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
@4brunu you was right. I checked it again, was my fault. moshiBuilder/gsonBuilder as lazy is not neccessary. I changed it also back to val instead of var, like before |
The PR ir really big, and a bit difficult to review. |
Thats a good question. The kotlin-retrofit2 library was too simple. We tooked most parts from java-retrofit2. Because of that, its such a big PR |
I saw that you changed the path of all the sample projects, and I think that's whats causing some many files being changed. |
Ok, so do i have to close these PR and create a clean, new one? |
No, you can keep this one open. |
@wing328 I will make a new/simpler PR without renaming etc |
I will make a new PR within the next few weeks hopefully |
#5076
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.PR Description
This PR add the option to use koltin suspend functions combined with retrofit2. Also adds more complexity (authorization) and ability to customization to the ApiClient.
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu