[Kotlin][Client] Fix url path for Retrofit, Fix optionals for @Query @Body, Set List as default collection for Kotlin data class

[kuFEAR]

I got some fixes from PR #5697

1. Fix url path for Retrofit
2. Fix optionals for @query @Body in requests
3. Set List as default collection for Kotlin data class, because data classes require override hashCode and equals methods
4. Small template formatting improvement

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
  @4brunu @wing328 @ch4rl3x

[4brunu]

Can you please fix those tests?

e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (25, 33): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (27, 28): Type inference failed. Expected type mismatch: inferred type is Array<Tag> but List<Tag>? was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (47, 47): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (55, 48): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (66, 33): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/StoreApiTest.kt: (21, 29): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected

The PR is very big, because it changes a lot of things in the sample projects.
But it looks good.

[kuFEAR]

Can you please fix those tests?

e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (25, 33): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (27, 28): Type inference failed. Expected type mismatch: inferred type is Array<Tag> but List<Tag>? was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (47, 47): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (55, 48): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/PetApiTest.kt: (66, 33): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected
e: /root/src/github.com/OpenAPITools/openapi-generator/samples/client/petstore/kotlin/src/test/kotlin/org/openapitools/client/StoreApiTest.kt: (21, 29): Type inference failed. Expected type mismatch: inferred type is Array<String> but List<String> was expected

The PR is very big, because it changes a lot of things in the sample projects.
But it looks good.

ff3f63d but when I run test locally it failed with com.squareup.moshi.LinkedHashTreeMap cannot be cast to org.openapitools.client.models.Pet

[kuFEAR]

The PR is very big

yeah, every time when changed some basic template we should update all kotlin-* scripts)

[kuFEAR]

@wing328 Are you planning to merge #6585 and this PR into 5.0.0?

[kuFEAR]

after merging ccb5ae7 when I ran generate-samples.sh for kotlin* I don't have changes as on circleCI like:

-@Api(value = "Pet", description = "The Pet API")
+@Api(value = "pet", description = "The pet API")

on my branch it still generate with as "Pet"
@4brunu @wing328 any idea how to fix it?

[wing328]

CC @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

[wing328]

I've merged the latest master and update the Kotlin samples. Let's see how it goes.

[kuFEAR]

I've merged the latest master and update the Kotlin samples. Let's see how it goes.

now I saw https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/3497/workflows/345773ae-ab74-4162-a8c5-1592ae010e4f/jobs/16865/parallel-runs/2?filterBy=FAILED there a lot not related with kotlin uncommited changes, go/apex/java-google-api

[wing328]

Not sure how but some of your changes update apex, go, etc petstore samples. I've pushed another update by updating all samples. Let's see how it goes.

[wing328]

If no further question/feedback on this PR, I'll merge it tomorrow (Tuesday)