Skip to content

Various UI improvements, some small some large #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joeytwiddle opened this issue Jul 3, 2014 · 4 comments
Closed

Various UI improvements, some small some large #241

joeytwiddle opened this issue Jul 3, 2014 · 4 comments
Labels
invalid Try, try again.

Comments

@joeytwiddle
Copy link
Contributor

  • I noticed the button to [Submit] an issue, and the button to [Reply] to an issue were very faint. I thought they were disabled! Only when I hovered over them did I realise they were actually available to click.
  • I did not notice that the search box on the right would search only the scripts of the user when I am on a user's page. It does say "Search user's script" but to make it clearer for people like myself it could say "Search jerome's scripts".
  • It's nice how the comments box pops up when I reach the bottom of the issues page, but it takes half the page! It would be nice if it would disappear again away when I scroll up (assuming I haven't typed anything in it).
  • It would be awesome to be able to edit comments like you can on Github. Then you can waffle on for hours without actually bothering anyone with notifications. 😄
  • When browsing the main scripts list, it would be nice to have [Previous] and [Next] buttons as well as the 1 | 2 | 3 | 4 | 5 | ... pager.
  • When viewing a script's source, there should be a title at the top of the page, e.g. "Source of script %author / %script_name". Also it might be nice to have an [Install] button. A user might want to browse the source of a script before installing it, so we should let her do that from the source page. In fact we should probably just re-use the [About | Source | Issues] tab group on the script's main page.
@Martii Martii added UI labels Jul 3, 2014
@joeytwiddle joeytwiddle changed the title Styling (minor): Buttons are too faded when unfocused Styling (minor): Buttons are too faded when unfocused, and some other UI suggestions Jul 4, 2014
@joeytwiddle joeytwiddle changed the title Styling (minor): Buttons are too faded when unfocused, and some other UI suggestions Various UI improvements, some small some large Jul 6, 2014
@Martii
Copy link
Member

Martii commented Jul 6, 2014

Change this issue too much more and it will end up as a duplicate. A few of these may already be well established issues or already commented on. Please read the CONTRIBUTING.md as it covers this.

@sizzlemctwizzle sizzlemctwizzle added invalid and removed UI labels Jul 6, 2014
@sizzlemctwizzle
Copy link
Member

It would be awesome to be able to edit comments like you can on Github.

I've probably said this a thousand times, but the discussion system is still unfinished. There are many features that are missing besides editing.

Various UI improvements

Editing comments is much more than a UI improvement. It's a feature (requiring DB and middleware code as well). This issue is all over the place. I'd rather have you open 6 small issues than one issue with them all crammed in (at least then I could label and close the duplicates). How are we suppose to conduct a meaningful discussion regarding 6 separate subjects? Plus some of these are known and discussed elsewhere (off the top of my head I can reduce it to 3), which makes me believe you didn't search existing issues. I refuse to accept heterogeneous issues (a off-topic comment is okay, but a vague topic is not). I'm closing this issue as "invalid".

@Zren
Copy link
Contributor

Zren commented Jul 7, 2014

When browsing the main scripts list, it would be nice to have [Previous] and [Next] buttons as well as the 1 | 2 | 3 | 4 | 5 | ... pager.

Can do. I had to make my own code for that as none of the existing ones generated html for bootstrap 3.

noticed the button to [Submit] an issue, and the button to [Reply] to an issue were very faint. I thought they were disabled! Only when I hovered over them did I realise they were actually available to click.

Probably need to have the :hover on the entire comment body as well and not just the button area.

I did not notice that the search box on the right would search only the scripts of the user when I am on a user's page. It does say "Search user's script" but to make it clearer for people like myself it could say "Search jerome's scripts".

Neat idea.

When viewing a script's source, there should be a title at the top of the page, e.g. "Source of script %author / %script_name". Also it might be nice to have an [Install] button. A user might want to browse the source of a script before installing it, so we should let her do that from the source page. In fact we should probably just re-use the [About | Source | Issues] tab group on the script's main page.

This... hasn't been done yet. Woops. There's another issue for it as well.

@Martii
Copy link
Member

Martii commented Jul 7, 2014

@Zren
Assuming the time is available please make separate issue tickets for any that you might be willing to take on. I seem to recall that there was some feedback for previous and next against implementing... e.g. please don't just "sneak it in" without isolating the issue first. :)

Zren added a commit to Zren/OpenUserJS.org that referenced this issue Jul 10, 2014
sizzlemctwizzle added a commit that referenced this issue Jul 11, 2014
#241 "Search user's script" -> "Search jerome's scripts"
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jul 12, 2014
sizzlemctwizzle added a commit that referenced this issue Jul 12, 2014
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid Try, try again.
Development

No branches or pull requests

4 participants