Skip to content

#241 "Search user's script" -> "Search jerome's scripts" #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

Zren
Copy link
Contributor

@Zren Zren commented Jul 10, 2014

I did not notice that the search box on the right would search only the scripts of the user when I am on a user's page. It does say "Search user's script" but to make it clearer for people like myself it could say "Search jerome's scripts".

Untested code, writing from elsewhere.

@Zren Zren added UI and removed needs testing labels Jul 10, 2014
@Martii
Copy link
Member

Martii commented Jul 10, 2014

EDIT: Works on dev with this pr checkout under the whole accounts we have there with scripts. ;) /me wonders about searching scripts from a fictional Miss's account but this is definitely not blocking I think. :)

@Martii
Copy link
Member

Martii commented Jul 11, 2014

@Zren
Would you mind considering changing the text to "Search Scripts from Username" and "Search Comments from Username" please? :) I just thought of a use case if a username is super long and/or the view port is super small. I'd rather see cutting off the last part of their Username rather than what the functionality is... Possibly better for translations too. Thanks.

click to enlarge sample


Not blocking but will probably be redressed again if this gets merged... later today things will be merged and deployed so best to get any changes in as soon as possible. :)

sizzlemctwizzle added a commit that referenced this pull request Jul 11, 2014
#241 "Search user's script" -> "Search jerome's scripts"
@sizzlemctwizzle sizzlemctwizzle merged commit 738f894 into OpenUserJS:master Jul 11, 2014
@Martii
Copy link
Member

Martii commented Jul 11, 2014

Check... working.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jul 12, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

3 participants