Skip to content

GDPR13 #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018
Merged

GDPR13 #1508

merged 1 commit into from
Jul 23, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 23, 2018

  • Some tempering for SEO vs. GDPR
  • Add a helper to be used for determining if is our site/pro/dev ... local pro will take some additional changes. Getting duplicated re's in several areas that do this. This is node@10.x specific using WHATWG instead of legacy. Loosely related to Squash a deprecation warning #1481

NOTE:

  • link and area not currently whitelisted so ignoring but still mitigate possible security risk for GDPR

Ref(s):


Backref #190

* Some tempering for SEO vs. GDPR
* Add a helper to be used for determining if is our site/pro/dev ... local pro will take some additional changes. Getting duplicated re's in several areas that do this. This is *node*@10.x specific using WHATWG instead of legacy. Loosely related to OpenUserJS#1481

NOTE:
* `link` and `area` not currently whitelisted so ignoring but still mitigate possible security risk for GDPR

Ref(s):
* http://w3c.github.io/html/links.html#allowed-keywords-and-their-meanings
* https://www.w3.org/TR/2014/REC-html5-20141028/links.html#link-type-prefetch
* https://www.w3.org/TR/referrer-policy/#referrer-policy-same-origin
@Martii Martii added UI Pertains inclusively to the User Interface. security Usually relates to something critical. DOC Pertains inclusively to the Documentation operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 23, 2018
@Martii Martii added this to the SEO milestone Jul 23, 2018
@Martii Martii merged commit 488da46 into OpenUserJS:master Jul 23, 2018
@Martii Martii deleted the GDPR13 branch July 23, 2018 10:46
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 24, 2018
* Fix bug on Issue page when isSameOrigin ... no need to display
* Fix bug *(A)* on relative library ... post OpenUserJS#502
* Fill in some other areas with this migration
* Reuse some of the code where applicable
* Set some more DOM client-side to experimental `referrerpolicy'
* Some STYLEGUIDE.md reconformance ... break after operators

NOTES:
* Test patterns for relative libs *(needs GM4 testing but pre passes)*

``` js
// These typically should show
// @require       http://localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       //localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       /src/libs/Marti/GM_setStyle.js

// These typically should not show
// @require       localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       Marti/GM_setStyle.js
// @require       GM_setStyle.js

```

* One more legacy URL API to migrate to WHATWG API ... need some of this PR in the wild for live tests
* Still needs possible local pro changes ... that is probably system wide and "big"... so will isolate

Post OpenUserJS#1508
@Martii Martii mentioned this pull request Jul 24, 2018
Martii added a commit that referenced this pull request Jul 24, 2018
* Fix bug on Issue page when isSameOrigin ... no need to display
* Fix bug *(A)* on relative library ... post #502
* Fill in some other areas with this migration
* Reuse some of the code where applicable
* Set some more DOM client-side to experimental `referrerpolicy'
* Some STYLEGUIDE.md reconformance ... break after operators

NOTES:
* Test patterns for relative libs *(needs GM4 testing but pre passes)*

``` js
// These typically should show
// @require       http://localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       //localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       /src/libs/Marti/GM_setStyle.js

// These typically should not show
// @require       localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       Marti/GM_setStyle.js
// @require       GM_setStyle.js

```

* One more legacy URL API to migrate to WHATWG API ... need some of this PR in the wild for live tests
* Still needs possible local pro changes ... that is probably system wide and "big"... so will isolate

Post #1508
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 24, 2018
* Silent failure on pro/dev with invalid grouping... doesn't trip server which is odd. Still an issue

Post OpenUserJS#1508 OpenUserJS#1509
@Martii Martii mentioned this pull request Jul 24, 2018
Martii added a commit that referenced this pull request Jul 24, 2018
* Silent failure on pro/dev with invalid grouping... doesn't trip server which is odd. Still an issue

Post #1508 #1509

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 24, 2018
* Alternate grouping... similar yet fuzzy

Post OpenUserJS#1508 OpenUserJS#1509 OpenUserJS#1510
@Martii Martii mentioned this pull request Jul 24, 2018
Martii added a commit that referenced this pull request Jul 24, 2018
* Alternate grouping... similar yet fuzzy

Post #1508 #1509 #1510

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 25, 2018
* SEO only allowed sites for user content areas. TOS enforcement.

NOTE(s):
* `google.com` is explicitly not included as domain is too broad for all services worldwide
* May alter this list

Post OpenUserJS#1508
@Martii Martii mentioned this pull request Jul 25, 2018
Martii added a commit that referenced this pull request Jul 25, 2018
* SEO only allowed sites for user content areas. TOS enforcement.

NOTE(s):
* `google.com` is explicitly not included as domain is too broad for all services worldwide
* May alter this list

Post #1508

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DOC Pertains inclusively to the Documentation operations. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant