Skip to content

GDPR13A #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

GDPR13A #1509

merged 1 commit into from
Jul 24, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 24, 2018 •
edited
Loading

  • Fix bug on Issue page when isSameOrigin ... no need to display
  • Fix bug (A) on relative library ... post Relative library urls inconsistent #502 (needs mitigation on PRO... reimported script and it passes by resetting DB in that use case)
  • Fill in some other areas with this migration
  • Reuse some of the code where applicable
  • Set some more DOM client-side to experimental `referrerpolicy'
  • Some STYLEGUIDE.md reconformance ... break after operators

NOTES:

  • Test patterns for relative libs (needs GM4 testing but pre passes)
// These typically should show
// @require       http://localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       //localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       /src/libs/Marti/GM_setStyle.js

// These typically should not show
// @require       localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       Marti/GM_setStyle.js
// @require       GM_setStyle.js
  • One more legacy URL API to migrate to WHATWG API ... need some of this PR in the wild for live tests
  • Still needs possible local pro changes ... that is probably system wide and "big"... so will isolate

Post #1508

@Martii
GDPR13A
3449297 
* Fix bug on Issue page when isSameOrigin ... no need to display
* Fix bug *(A)* on relative library ... post OpenUserJS#502
* Fill in some other areas with this migration
* Reuse some of the code where applicable
* Set some more DOM client-side to experimental `referrerpolicy'
* Some STYLEGUIDE.md reconformance ... break after operators

NOTES:
* Test patterns for relative libs *(needs GM4 testing but pre passes)*

``` js
// These typically should show
// @require       http://localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       //localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       /src/libs/Marti/GM_setStyle.js

// These typically should not show
// @require       localhost:8080/src/libs/Marti/GM_setStyle.js
// @require       Marti/GM_setStyle.js
// @require       GM_setStyle.js

```

* One more legacy URL API to migrate to WHATWG API ... need some of this PR in the wild for live tests
* Still needs possible local pro changes ... that is probably system wide and "big"... so will isolate

Post OpenUserJS#1508
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. security Usually relates to something critical. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 24, 2018
@Martii Martii merged commit 56125e7 into OpenUserJS:master Jul 24, 2018
@Martii Martii deleted the GDPR13A branch July 24, 2018 12:39
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 24, 2018
@Martii
GDPR13B
5b2929d 
* Silent failure on pro/dev with invalid grouping... doesn't trip server which is odd. Still an issue

Post OpenUserJS#1508 OpenUserJS#1509
@Martii Martii mentioned this pull request Jul 24, 2018
Merged
Martii added a commit that referenced this pull request Jul 24, 2018
@Martii
GDPR13B (#1510)
22f2b56 
* Silent failure on pro/dev with invalid grouping... doesn't trip server which is odd. Still an issue

Post #1508 #1509

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 24, 2018
@Martii
GDPR13B1
8a8ef0c 
* Alternate grouping... similar yet fuzzy

Post OpenUserJS#1508 OpenUserJS#1509 OpenUserJS#1510
@Martii Martii mentioned this pull request Jul 24, 2018
Merged
Martii added a commit that referenced this pull request Jul 24, 2018
@Martii
GDPR13B1 (#1511)
49a72e0 
* Alternate grouping... similar yet fuzzy

Post #1508 #1509 #1510

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii