Calculation engine array formulae initial work #2539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supports the basic happy path (no handling for Error results when reading) No functionality yet for setting array formulae in code
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
b9a7aed to
8156ed9
Compare
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
6672dbc to
39a6c29
Compare
added 2 commits
January 30, 2022 22:19
…ibutes are being set correctly
added 4 commits
January 31, 2022 18:25
… spillage cells when calculating the value No provision yet for the single operator, or for handlng #SPILL! or #CALC! errors
…on is written and linked; and then tag array formula cells with the `cm` tag to link them to that cell metadata definition
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
2793171 to
d2435cd
Compare
added 3 commits
February 2, 2022 12:51
…mula range dimensions, expanding or shrinking it as necessary.
…containing an array formula
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
2 times, most recently
from
d854d5b to
5b322f3
Compare
added 7 commits
February 4, 2022 10:18
…AY()`) and Single (`SINGLE()`) Operators
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
5b322f3 to
593a9f0
Compare
added 2 commits
February 4, 2022 11:24
…or Cell's setValueExplicit() method
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
593a9f0 to
3cec90d
Compare
Note that the deprecated Excel function implementation classes should be removed completely for PhpSpreadsheet 2.0.0; and the bc break that array formula handling entails will require this to be a 2.0.0 implementation... but just for the moment, this is a cleanup... those files will be deleted once we switch to development on a 2.0-dev branch, and I want to do a few more PR merges before then, and update this branch as part of the 2.0-dev changes
MarkBaker
added
the
writer/ods
added 22 commits
April 12, 2022 08:58
# Conflicts: # phpstan-baseline.neon # src/PhpSpreadsheet/Worksheet/Worksheet.php
Start removing some of the deprecations, starting with the old Excel Function implementations.
… indicator that a method should be internal only
# Conflicts: # docs/references/function-list-by-category.md # docs/references/function-list-by-name.md # phpstan-baseline.neon # src/PhpSpreadsheet/Worksheet/Worksheet.php
# Conflicts: # phpstan-baseline.neon
# Conflicts: # phpstan-baseline.neon # src/PhpSpreadsheet/Calculation/Calculation.php
# Conflicts: # phpstan-baseline.neon
…Initial-Work # Conflicts: # phpstan-baseline.neon # src/PhpSpreadsheet/Calculation/Calculation.php # src/PhpSpreadsheet/Calculation/Functions.php # src/PhpSpreadsheet/Calculation/MathTrig.php
…Initial-Work # Conflicts: # phpstan-baseline.neon
MarkBaker
force-pushed
the
CalculationEngine-Array-Formulae-Initial-Work
branch
from
4c46566 to
b1d1ce7
Compare
added 4 commits
June 18, 2022 13:00
# Conflicts: # phpstan-baseline.neon
…Initial-Work # Conflicts: # phpstan-baseline.neon # tests/PhpSpreadsheetTests/Worksheet/WorksheetTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Initial support for reading/writing array formulae with the Xlsx Reader/Writer
Work to allow setting array formulae from userland code looks like it will create a BC break. It requires extra arguments for the Cell
setValue()andsetValueExplicit()methods - the equivalent of pressing Ctrl-Enter when entering an array formula in MS Excel - (unless I can come up with some creative alternative, like executing the formula at the point when it is set to identify if it is an array formula or not; and if so, what the spillage cell range should be); and these additional arguments must be passed to the Cell Binder creating a BC break for the BinderInterface.