Skip to content

Use property scope in ISE theme #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

TylerLeonhardt
Copy link
Member

PR Summary

Goes with PowerShell/PowerShellEditorServices#1337

image
before and after

ISE:
image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests N/A
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt
Copy link
Member Author

@justinytchen what do you think?

@TylerLeonhardt
Copy link
Member Author

This change was due to @PrzemyslawKlys tweet about the Monokai theme:
https://twitter.com/PrzemyslawKlys/status/1288961019373649920?s=20

@PrzemyslawKlys
Copy link
Contributor

Does this mean my issue will be gone (as in reverted for non ISE theme) or that I will be able to control those colors or better that those colors would be taken from the theme natively?

It does seem to give some benefits I guess - just the colors are not really something I would like to keep :-)

image

image

image

@PrzemyslawKlys
Copy link
Contributor

Never mind, I see the other issue that demonstrates it. Thank you!

@TylerLeonhardt TylerLeonhardt merged commit 2d30df7 into PowerShell:master Jul 31, 2020
@TylerLeonhardt TylerLeonhardt deleted the use-property-scope branch August 10, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants