Refactor syllable.py to use set for thai_consonants_all #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bact
approved these changes
Mar 30, 2025
bact
added
the
refactoring
wannaphong
added a commit
that referenced
this pull request
Mar 31, 2025
Merged
bact
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
Switches
thai_consonants_allfrom alistto asetin pythainlp/util/syllable.py and simplifies its use in sound_syllable.What was wrong
Its not wrong, but the original code used
if i in list(thai_consonants_all)for membership checks, which was less efficient due to list’s O(n) lookup time.How this fixes it
Using a set for
thai_consonants_allcleans up the code toif i in thai_consonants_all, leverages set’s O(1) lookups for speed, and maintains identical logic with no downsides.Your checklist for this pull request