Skip to content

ThaiTransliterator: Select 1D CPU int64 tensor device #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

jkingd0n
Copy link
Contributor

What does this changes

Fixes #1088

What was wrong

Tensors not using correct torch device.

How this fixes it

Explicitly sets device.

Your checklist for this pull request

  • Passed code styles and structures
  • Passed code linting checks and unit test

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkingd0n jkingd0n mentioned this pull request Mar 30, 2025
@bact bact added the bug bugs in the library label Mar 30, 2025
@bact bact changed the title fix #1088 ThaiTransliterator: Select 1D CPU int64 tensor device Mar 31, 2025
wannaphong added a commit that referenced this pull request Mar 31, 2025
- PR Description: Refactor thai_consonants_all to Use set in syllable.py #1087  @allrob23
-  ThaiTransliterator: Select 1D CPU int64 tensor device #1089 @jkingd0n
@wannaphong wannaphong mentioned this pull request Mar 31, 2025
@wannaphong wannaphong merged commit 8bbdb2d into PyThaiNLP:dev Mar 31, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: thai2rom errors
3 participants