Skip to content

feature: Per course status page #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2021
Merged

feature: Per course status page #348

merged 5 commits into from
Oct 18, 2021

Conversation

yammesicka
Copy link
Member

Also, lots of small improvements:

  • Hebrew strings fixes
  • Removing cluttered suggestions from views.py
  • Better migration setup - create tables that doesn't exist first
  • Tests for the status page

Also, lots of small improvements:
- Hebrew strings fixes
- Removing cluttered suggestions from views.py
- Better migration setup - create tables that doesn't exist first
- Tests for the status page
@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #348 (9467f84) into master (a787de9) will increase coverage by 0.10%.
The diff coverage is 44.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   84.08%   84.18%   +0.10%     
==========================================
  Files          63       63              
  Lines        2946     2953       +7     
==========================================
+ Hits         2477     2486       +9     
+ Misses        469      467       -2     
Impacted Files Coverage Δ
lms/models/solutions.py 98.97% <ø> (ø)
lms/lmsdb/bootstrap.py 16.45% <18.75%> (+0.66%) ⬆️
lms/lmsweb/views.py 92.93% <80.00%> (-0.19%) ⬇️
lms/lmsdb/models.py 91.95% <100.00%> (+0.87%) ⬆️
lms/models/comments.py 80.39% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a787de9...9467f84. Read the comment docs.

@yammesicka yammesicka requested a review from orronai October 17, 2021 00:08
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 18, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 2.36 ⭐ 2.25 ⭐ -0.11 👍
Method Length 39.59 ⭐ 39.27 ⭐ -0.32 👍
Working memory 6.80 🙂 6.84 🙂 0.04 👎
Quality 79.63% 79.86% 0.23% 👍
Other metrics Before After Change
Lines 2000 2012 12
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 79.77% ⭐ 81.17% ⭐ 1.40% 👍
lms/lmsdb/models.py 84.48% ⭐ 84.12% ⭐ -0.36% 👎
lms/lmsweb/views.py 75.31% ⭐ 75.40% ⭐ 0.09% 👍
lms/models/solutions.py 74.82% 🙂 75.04% ⭐ 0.22% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsweb/views.py comment 13 🙂 202 😞 8 🙂 50.15% 🙂 Try splitting into smaller methods
lms/lmsdb/models.py Solution.status 1 ⭐ 118 🙂 17 ⛔ 55.65% 🙂 Extract out complex expressions
lms/lmsweb/views.py view 8 ⭐ 140 😞 10 😞 56.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py login 5 ⭐ 129 😞 12 😞 56.69% 🙂 Try splitting into smaller methods. Extract out complex expressions
lms/models/solutions.py get_view_parameters 5 ⭐ 128 😞 12 😞 56.81% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@yammesicka yammesicka merged commit 9499e89 into master Oct 18, 2021
@yammesicka yammesicka deleted the better-status-page branch October 18, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants