[utest][kernel_irq] add the utest of irq #4951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guozhanxin
reviewed
Aug 18, 2021
Guozhanxin
reviewed
Aug 18, 2021
Guozhanxin
reviewed
Aug 18, 2021
Guozhanxin
approved these changes
Aug 18, 2021
|
涛哥，我看你这个里面只测试了sethook和获取嵌套层数。开关中断是不是也想办法加两个测试项上来啊？还是说再单独提个pr？ |
发现个小问题：你们只有sethook，没有unsethook。感觉测试之后恢复不到之前的状态。这个不知道有么有solution？ 开关总中断，这个要怎么测试呢？想不到怎么测。提供如何测试，后面可以考虑再提个PR。 |
sethook为空就好了啊 |
哦 |
|
涛哥，合并event之后这个冲突了，你再改一下吧 |
好的 |
supperthomas
force-pushed
the
add_kernel_irq_utest
branch
from
ce6dfdd to
1904811
Compare
supperthomas
force-pushed
the
add_kernel_irq_utest
branch
from
1904811 to
b4a46f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[add the utest of irq.c]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up