Skip to content

[HUST CSE][bsp]fix mismatched function types in rt_pin_ops for all drv_gpio.c #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Conversation

XLOverflow
Copy link
Contributor

@XLOverflow XLOverflow commented Apr 6, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

经由[HUST CSE][bsp] fix mismatched function types in rt_pin_ops为启发,当时只发现一个板子上的问题,故只修改了一个文件。然后发现除少部分drv_gpio.c文件变量类型正确无误外,下面所列出的文件均有类型不匹配的问题。

  1. bsp/ESP32_C3/drivers/drv_gpio.c
  2. bsp/Vango/v85xx/drivers/drv_gpio.c
  3. bsp/Vango/v85xxp/drivers/drv_gpio.c
  4. bsp/acm32/acm32f0x0-nucleo/drivers/drv_gpio.c
  5. bsp/acm32/acm32f4xx-nucleo/drivers/drv_gpio.c
  6. bsp/airm2m/air105/libraries/rt_drivers/drv_gpio.c
  7. bsp/airm2m/air32f103/libraries/rt_drivers/drv_gpio.c
  8. bsp/allwinner_tina/drivers/drv_gpio.c
  9. bsp/bluetrum/libraries/hal_drivers/drv_gpio.c

你的解决方案是什么 (what is your solution)

将drv_gpio.c的不匹配字段按照应有的类型做出一定的修改。

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@XLOverflow XLOverflow changed the title [HUST CSE]bsp:fix mismatched function types in rt_pin_ops for all drv_gpio.c [HUST CSE][bsp]fix mismatched function types in rt_pin_ops for all drv_gpio.c Apr 6, 2023
@mysterywolf
Copy link
Member

mysterywolf commented Apr 6, 2023

谢谢,这个应该还有一些 有时间也多帮忙检查一下 pin框架数据类型变更之后,bsp的驱动数据类型没有都来得及跟随变更,更改之后编译如果不再有警告就没啥问题了

@mysterywolf mysterywolf added the good first issue Good for newcomers 新手任务 label Apr 6, 2023
@mysterywolf mysterywolf requested a review from Guozhanxin April 7, 2023 01:13
XLOverflow and others added 2 commits April 7, 2023 11:29
Co-authored-by: Man, Jianting (Meco) <[email protected]>
Co-authored-by: Man, Jianting (Meco) <[email protected]>
@mysterywolf mysterywolf merged commit 5554bb5 into RT-Thread:master Apr 7, 2023
@mysterywolf
Copy link
Member

感谢提交PR!

@mysterywolf mysterywolf added the University: HUST IoTS&P Lab 华中科技大学网络空间安全学院 label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 新手任务 University: HUST IoTS&P Lab 华中科技大学网络空间安全学院
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants