-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(drivers/usb):replace rtt usb stack with cherryusb #8799
Merged
+245,858
−1,809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
目录结构上没问题,不过代码头的版权协议建议仔细捋捋 |
指的是文件里缺失license的地方吗 |
是的,一些文件是没有版权信息的,这样容易引起纠纷 |
ef4f51f
to
82bafd2
Compare
BernardXiong
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the old if as a package
mysterywolf
requested changes
Apr 23, 2024
mysterywolf
approved these changes
Apr 23, 2024
280138f
to
78f0002
Compare
能不能开放支持不带dma功能的ip做主机使用? |
不带dma的ip,功能太弱,中断太频繁,处理太麻烦,很容易出问题,所以不考虑做,我只支持全功能的 IP,多谢 |
518a377
to
b13470b
Compare
f77c3b8
to
0a6f16f
Compare
aef0f6d
to
821f911
Compare
BernardXiong
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
最终目的:使用 cherryusb 替换 rtthread 自带的 usb 协议栈。当前版本 cherryusb 1.3.0.
替换流程:
1,将原有的 usb stack 移动到 components/legacy 目录下,用于使用 rtt usb stack的用户
2,增加 cherryusb 至 drivers/usb 目录
3,选择部分bsp 增加 cherryusb 适配(主要增加非 IP 级别的底层驱动和 usb 初始化),其中 usb_config.h 目前是放在bsp中,每个 bsp会单独管理 usb_config.h。
4,目前已经适配 bouffalolab(bl616), 其余 bsp待定(需要先确定前面三步是否合理)
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up