feat(ui5-timepicker): implement new component #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents into timepicker-implementation
ilhan007
requested changes
Mar 16, 2020
ilhan007
requested changes
Mar 18, 2020
There was a problem hiding this comment.
Most of the previous comments are resolved, I found couple of things
- The arrow buttons
Currently the arrow looks like this
But, in openui5 looks like this:
- The width of the pop up
In openui5 no matter the number of sliders (1 or 4) the with of the pop up remains the same, not the case with the current implementation
Image from openui5:
- How the picker looks on phone
3.1. When I open the picker with the chrome emulator, none of the sliders is opened:
3.2. When I open the picker with the chrome emulator, the sliders should take the full height, but not:
ilhan007
requested changes
Mar 18, 2020
ilhan007
previously requested changes
Mar 20, 2020
vladitasev
requested changes
Mar 23, 2020
vladitasev
previously approved these changes
Mar 23, 2020
vladitasev
approved these changes
Mar 24, 2020
MapTo0
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist