feat: add support for angular two way data binding #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fifoosid I have the context and I agree with the changes, but if there should be comments that it's done to enable two-way data binding, please add that it is for Angular |
vladitasev
requested changes
Aug 5, 2019
| @@ -327,6 +327,8 @@ class DatePicker extends UI5Element { | |||
|
|
|||
| this.value = nextValue; | |||
| this.fireEvent("change", { value: nextValue, valid: isValid }); | |||
| // Two way data binding | |||
| this.fireEvent("value-changed", { value: nextValue, valid: isValid }); | |||
There was a problem hiding this comment.
Please check no-conflict mode (should not fire ui5- for value-changed)
fifoosid
changed the title
ilhan007
reviewed
Aug 13, 2019
| @@ -1,9 +1,17 @@ | |||
| import { getNoConflict as getConfiguredNoConflict } from "../InitialConfiguration.js"; | |||
|
|
|||
| const twoWayDataBindingEvents = [ | |||
There was a problem hiding this comment.
twoWayDataBindingEvents too specific, excludeList or something similar
isTwoWayDataBindingEvent as well, skipPrefix, isEventExcluded or similar
ilhan007
reviewed
Aug 14, 2019
vladitasev
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.