-
Notifications
You must be signed in to change notification settings - Fork 273
feat: add support for angular two way data binding #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d072f6c
add comments
fifoosid 0aca891
fix param
fifoosid c1b77be
Merge remote-tracking branch 'origin/master' into data-binding
vladitasev 415be65
add comments
fifoosid 6c2675f
Merge branch 'master' into data-binding
fifoosid 6e75582
Merge branch 'data-binding' of https://github.com/SAP/ui5-webcomponen…
fifoosid dc8acbc
fire value-changed event in noconflict mode
fifoosid 35a9025
fix eslint
fifoosid d157ee3
don't fire ui5-value-changed
fifoosid 21122ca
respect public api
fifoosid 2c72471
rename methods
fifoosid 70023a0
fix linter
fifoosid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,44 @@ | ||
import { getNoConflict as getConfiguredNoConflict } from "../InitialConfiguration.js"; | ||
|
||
// Fire these events even with noConflict: true | ||
const excludeList = [ | ||
"value-changed", | ||
]; | ||
|
||
const shouldFireOriginalEvent = eventName => { | ||
return excludeList.includes(eventName); | ||
}; | ||
|
||
let noConflict = getConfiguredNoConflict(); | ||
|
||
const shouldNotFireOriginalEvent = eventName => { | ||
return !(noConflict.events && noConflict.events.includes && noConflict.events.includes(eventName)); | ||
}; | ||
|
||
const getNoConflict = () => { | ||
return noConflict; | ||
}; | ||
|
||
const skipOriginalEvent = eventName => { | ||
// Always fire these events | ||
if (shouldFireOriginalEvent(eventName)) { | ||
return false; | ||
} | ||
|
||
// Read from the configuration | ||
if (noConflict === true) { | ||
return true; | ||
} | ||
|
||
return !shouldNotFireOriginalEvent(eventName); | ||
}; | ||
|
||
const setNoConflict = noConflictData => { | ||
noConflict = noConflictData; | ||
}; | ||
|
||
export { | ||
getNoConflict, | ||
setNoConflict, | ||
skipOriginalEvent, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check no-conflict mode (should not fire ui5- for value-changed)