-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[🚀 Feature]: Expand CI Coverage #11305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@titusfortner, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
So, RBE is doing this:
But it is all on Linux and I'm not sure which all browsers are included for the different bindings. I don't understand why Java is limiting things the way it does, and I'm not sure if it is still testing pre-release browsers (which I don't actually want it to). RBE is great, but seems limiting still? Should we be doing a CI run with Windows & Mac tests? At any rate, we still need to discuss what we want here. |
It is more important to run tests on beta and dev browsers because we can catch things there, like the issue with Firefox 121. I would put more effort into doing nightly releases and run the code examples we have in the docs with those nightly releases in Linux, macOS, and Windows. |
I feel like failing beta is good for us to raise issues with Google and mozilla but shouldn't keep us from releasing. I guess as long as we can set guards separately for bugs... Agreed we should get nightlies for everything, but coverage in docs examples is going to be pretty light for a while still. My point with this is that we don't have an overall strategy, it's been a bunch of small decisions over time by many people as to what to do. |
I think as soon as Simon finishes upgrading to Bazel 7, we can try to build a matrix for each binding with:
Additionally, we can see we can hook tools like Dependabot/Renovate to automatically upgrade pinned browsers, including beta/dev versions. |
Well, we do need integration tests for Selenium Manager, so it can't all be pinned browsers. |
I suppose we can have few of them that are explicitly checking integration in each bindings. |
We now have Firefox, Firefox beta, Chrome and Edge running for Ruby on RBE. I believe we can shrink the current CI and to only things that are not tested on RBE (Safari, Selenium-Manager related tests, etc) |
This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stalled for 14 days with no activity. |
This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs. |
Feature and motivation
We should have better CI coverage before we do releases.
Update: Here's a spreadsheet with the current coverage
It's worth noting that not all Java tests run all the browsers, they have to be explicitly turned on per class.
@p0deje is adding Windows + Ruby support - #11295And also working on improving caching so we can reduce our total execution times to support adding more coverage.
Selenium Manager should make this much easier now that we don't have to fuss with drivers in the CI setup.
Things we're missing include:
No MacOS tests in any languageNo .NET tests at all (likely needs work from Bazel Build technical debt #10465)Specific Recommendations
Remove firefox-dev from Java; from @whimboo:(Done in 8f8bf8e)The text was updated successfully, but these errors were encountered: