Skip to content

[🚀 Feature]: Run tests on Mac in CI #12397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
titusfortner opened this issue Jul 21, 2023 · 3 comments · Fixed by #12556
Closed

[🚀 Feature]: Run tests on Mac in CI #12397

titusfortner opened this issue Jul 21, 2023 · 3 comments · Fixed by #12556
Labels
B-build Includes scripting, bazel and CI integrations I-enhancement Something could be better

Comments

@titusfortner
Copy link
Member

Feature and motivation

Something (maybe Ruby) needs to run on Mac. We don't have any coverage for Safari or for Selenium Manager actually working properly on Mac.

I happened to hit a selenium manager bug trying to do something before the upcoming release; we need CI to catch this.

Usage example

n/a
@titusfortner titusfortner added I-enhancement Something could be better B-build Includes scripting, bazel and CI integrations labels Jul 21, 2023
@karenhernandeze
Copy link

Can i work in this?

@titusfortner
Copy link
Member Author

Sure.

@LogicOscar LogicOscar mentioned this issue Aug 15, 2023
Merged
8 tasks
@titusfortner titusfortner mentioned this issue Aug 31, 2023
Closed
titusfortner added a commit that referenced this issue Sep 13, 2023
@LogicOscar @titusfortner
[rb] Add macos coverage to Ruby CI Github Action (#12556)
e518273 
* Add macos coverage to Ruby CI (#12397)

* guard is not present in before all hook so do not set driver

* after hook still executes even when guard disposition of the test is skip so explicitly skip it too

---------

Co-authored-by: Titus Fortner <[email protected]>
Co-authored-by: titusfortner <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
B-build Includes scripting, bazel and CI integrations I-enhancement Something could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rb] Add macos coverage to Ruby CI Github Action - Feat#12397 LogicOscar/selenium
2 participants
@titusfortner @karenhernandeze