Add more logging for node:atoms rake task #7707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddavison
reviewed
Oct 23, 2019
| Rake::Task['//javascript/atoms/fragments:is-displayed'].out, | ||
| Rake::Task['//javascript/webdriver/atoms:get-attribute'].out | ||
| ].each do |atom| | ||
| p rake_outs = [ |
There was a problem hiding this comment.
Suggested change
| p rake_outs = [ | |
| rake_outs = [ |
Looks like an extraneous inspect was left in here
There was a problem hiding this comment.
Well I left that in as well deliberately, just to try figure out what's going on.
But I'm convinced something else is awry. I'm not 100% sure though
|
Going to close this as convinced that this failure was just intermittent. I've had 2 PR's which haven't thrown this error, so reasonably convinced it's either isolated to the sonar upgrade or just because that branch is behind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementHelp triage #7704
Add extra logging when RakeOuts are not found during meta-programming phase.