Skip to content

Add more logging for node:atoms rake task #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add more logging for node:atoms rake task #7707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,17 +540,21 @@ namespace :jruby do
end

namespace :node do
task atoms: %w(
atom_list = %w(
//javascript/atoms/fragments:is-displayed
//javascript/webdriver/atoms:get-attribute
) do
)
task atoms: atom_list do
baseDir = 'javascript/node/selenium-webdriver/lib/atoms'
mkdir_p baseDir

[
Rake::Task['//javascript/atoms/fragments:is-displayed'].out,
Rake::Task['//javascript/webdriver/atoms:get-attribute'].out
].each do |atom|
p rake_outs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p rake_outs = [
rake_outs = [

Looks like an extraneous inspect was left in here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I left that in as well deliberately, just to try figure out what's going on.

But I'm convinced something else is awry. I'm not 100% sure though

Rake::Task[atom_list.first].out,
Rake::Task[atom_list.last].out
]

rake_outs.each do |atom|
puts "atom is #{atom}\n"
name = File.basename(atom)

puts "Generating #{atom} as #{name}"
Expand Down Expand Up @@ -585,11 +589,11 @@ namespace :node do
end

namespace :py do
task prep: [
'//javascript/atoms/fragments:is-displayed',
'//javascript/webdriver/atoms:get-attribute',
'//third_party/js/selenium:webdriver_xpi'
] do
task prep: %w(
//javascript/atoms/fragments:is-displayed
//javascript/webdriver/atoms:get-attribute
//third_party/js/selenium:webdriver_xpi
) do
py_home = 'py/'
remote_py_home = py_home + 'selenium/webdriver/remote/'
firefox_py_home = py_home + 'selenium/webdriver/firefox/'
Expand Down