Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Notes & PageFactory (Minor Fixes) #1394

Merged
merged 5 commits into from
May 29, 2023

Conversation

kathyrollo
Copy link
Contributor

Hey @diemol , complementary PR to #1387

Description

  • Added syntax highlighting for code examples.
  • Remove mentions of PageFactory.
  • Added emphasis on important points.
  • Minor additions to code comments for clarity.

Motivation and Context

  • Code samples must have syntax highlighting where possible to improve readability.
  • PageFactory has been discouraged for a while (Simon Stewart, SeleniumConf 2017) and should no longer be encouraged for Selenium 4.x onwards to modernise solutions.
  • Added mention of Martin Fowler's "panel objects" for historical significance, as the most common misconceptions of the Page Object stem from this missed footnote.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Sorry, something went wrong.

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit ec7858f
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/647439054609f50008404b75
😎 Deploy Preview https://deploy-preview-1394--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kathyrollo!

@diemol diemol merged commit 10e29aa into SeleniumHQ:trunk May 29, 2023
selenium-ci added a commit that referenced this pull request May 29, 2023
* Add syntax highlighting for code examples in Implementation notes

* Remove mentions of PageFactory (discouraged)

* Minor text and comment improvements

* Add emphasis on important points

* Update relevant pages - JA, PT-BR, ZH-CN

[deploy site] 10e29aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants